ostbuild: Make --shell-on-failure flag to work
authorAdrian Perez <aperez@igalia.com>
Wed, 2 May 2012 18:29:40 +0000 (21:29 +0300)
committerColin Walters <walters@verbum.org>
Fri, 4 May 2012 20:16:16 +0000 (16:16 -0400)
Fixes an issue which would cause ostbuild to fail to spawn the
debug shell and print a traceback instead.

src/ostbuild/pyostbuild/builtin_build_components.py

index 5983dea05ddcb3c37417ac861bbff124fc1ae9c6..11f45d4bd00f9115cd422c131927e508e4284baf 100755 (executable)
@@ -54,10 +54,10 @@ class OstbuildBuildComponents(builtins.Builtin):
                      '--snapshot=' + self.snapshot_path])
         return args
 
-    def _launch_debug_shell(self, architecture, buildroot, cwd=None):
+    def _launch_debug_shell(self, architecture, component, cwd=None):
         args = self._get_ostbuild_chroot_args(architecture)
-        args.extend(['--buildroot=' + buildroot,
-                     '--workdir=' + self.workdir,
+        args.extend(['--arch=' + architecture,
+                     '--name=' + component,
                      '--debug-shell'])
         run_sync(args, cwd=cwd, fatal_on_error=False, keep_stdin=True)
         fatal("Exiting after debug shell")
@@ -137,7 +137,7 @@ class OstbuildBuildComponents(builtins.Builtin):
         if self.buildopts.shell_on_failure:
             ecode = run_sync_monitor_log_file(chroot_args, log_path, cwd=component_src, fatal_on_error=False)
             if ecode != 0:
-                self._launch_debug_shell(architecture, buildroot_name, cwd=component_src)
+                self._launch_debug_shell(architecture, basename, cwd=component_src)
         else:
             run_sync_monitor_log_file(chroot_args, log_path, cwd=component_src)